Rocksolid Light - rocksolid.nodes.help - Re: bug in send.php/newsportal.php

bug in send.php/newsportal.php

<36ae70c4fcc9d0ec5b736712ed238e74@news.novabbs.org>

https://news.novabbs.org/computers/article-flat.php?id=536&group=rocksolid.nodes.help#536

copy link Newsgroups: rocksolid.nodes.help

Path: i2pn2.org!.POSTED!not-for-mail
From: vga@vga256.com (vga256)
Newsgroups: rocksolid.nodes.help
Subject: bug in send.php/newsportal.php
Date: Tue, 8 Aug 2023 16:26:04 +0000
Organization: Rocksolid Light
Message-ID: <36ae70c4fcc9d0ec5b736712ed238e74@news.novabbs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="1810050"; mail-complaints-to="usenet@i2pn2.org";
posting-account="PGd4t4cXnWwgUWG9VtTiCsm47oOWbHLcTr4rYoM0Edo";
User-Agent: Rocksolid Light 0.8.5
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on i2pn2.org
X-Rslight-Site: $2y$10$SDsonnAnL6GX9lsM664Dgey/6Td.JN/opD0m.zyc2sgU8siVogm/i
X-Rslight-Posting-User: 9d50238f0c8e65588ce75c7d7eaad42d47312328

by: vga256 - Tue, 8 Aug 2023 16:26 UTC

Submitting this one as a bug, since I *think* this is unintended behaviour - let me know if this was intended.

send.php, line 47:

$ns=nntp2_open($CONFIG['remote_server'], $CONFIG['remote_port']);

calls newsportal.php-> nntp2_open()

function nntp2_open($nserver=0,$nport=0) {
<snip>
here's where the problem is:

if($CONFIG['remote_ssl']) {

var_dump($ns = fsockopen("ssl://".$nserver, $nport, $error, $errorString, 30));

var_dump($errorString);

var_dump($error);

it is using $nport, which is always set to the non-SSL port. i tested this several times and it's always the same - it uses the non-SSL port no matter what.

here's the fix i propose:

// try to upgrade connection to SSL if enabled
if($CONFIG['remote_ssl']) {

$remote_ssl_port = $CONFIG['remote_ssl'];

var_dump($ns = fsockopen("ssl://".$nserver, $remote_ssl_port, $error, $errorString, 30));

--
Posted on Rocksolid Light

Re: bug in send.php/newsportal.php

<579256ed93740c28eb8db0e4141a1d50@rocksolidbbs.com>

copy mid

https://news.novabbs.org/computers/article-flat.php?id=538&group=rocksolid.nodes.help#538

copy link Newsgroups: rocksolid.nodes.help

Path: i2pn2.org!.POSTED!not-for-mail
From: retro.guy@rocksolidbbs.com (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: bug in send.php/newsportal.php
Date: Tue, 8 Aug 2023 16:36:22 +0000
Organization: RetroBBS
Message-ID: <579256ed93740c28eb8db0e4141a1d50@rocksolidbbs.com>
References: <36ae70c4fcc9d0ec5b736712ed238e74@news.novabbs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="1811005"; mail-complaints-to="usenet@i2pn2.org";
posting-account="qk6pvs/sIyKYNRNFdjVS+ghlZZkCUq7cWs+7p7kaLpU";
User-Agent: Rocksolid Light 0.8.5
X-Rslight-Site: $2y$10$e33PtiEfozjNmjRai/CJqOR6spDgfoY0IzqR.BrDeNaJh.PWBePYO
X-Face: .&YR-G(w(DZ$$,}%k=]*5*!p'=(anr"IT`wZG'2VWdfl\r)l[42u7JH`n(JUQ*e5*A|XCDf
?&\X&uwkl38"CYX3O8m}C8E4p'%N$2#kSTVzx{Ly|DjLT\Vk7NE}NQ(VC$Yq]i:7|z[.9iv^g>*8_B
H0=hZt'[%)4kG|
X-Rslight-Posting-User: 7f2224730128256930309c9186f6203084896743
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on i2pn2.org

by: Retro Guy - Tue, 8 Aug 2023 16:36 UTC

vga256 wrote:

> Submitting this one as a bug, since I *think* this is unintended behaviour - let me know if this was intended.

> send.php, line 47:

> $ns=nntp2_open($CONFIG['remote_server'], $CONFIG['remote_port']);

> calls newsportal.php-> nntp2_open()

> it is using $nport, which is always set to the non-SSL port. i tested this several times and it's always the same - it uses the non-SSL port no matter what.

Good catch! I will implement this change in rslight also. Thanks.

--
Retro Guy

Xerox never comes up with anything original.

computers / Rocksolid Nodes Help / Re: bug in send.php/newsportal.php

Subject	Author
bug in send.php/newsportal.php	vga256
bug in send.php/newsportal.php	Retro Guy